Skip to content

feature/activity-logs-team#176

Merged
mdawoud27 merged 7 commits into
mainfrom
feature/175/activity_logs_team
Apr 18, 2025
Merged

feature/activity-logs-team#176
mdawoud27 merged 7 commits into
mainfrom
feature/175/activity_logs_team

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #175

@mdawoud27 mdawoud27 added the enhancement New feature or request label Apr 18, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 18, 2025 20:48
@mdawoud27 mdawoud27 self-assigned this Apr 18, 2025
@mdawoud27 mdawoud27 linked an issue Apr 18, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds activity log integration for team-related endpoints to enable audit tracking for various team actions.

  • Introduces logging in endpoints for creating a team, adding/removing team members, updating team details, uploading/deleting team avatars, and deleting a team.
  • Imports utility functions to generate activity details and record logs.
Comments suppressed due to low confidence (2)

src/controllers/team.controller.js:850

  • Consider aligning the outer action ('UPDATED') with the inner detail action ('AVATAR_UPLOADED') to avoid ambiguity; for example, use 'AVATAR_UPLOADED' consistently for both.
action: 'AVATAR_UPLOADED',

src/controllers/team.controller.js:941

  • Consider aligning the outer action ('UPDATED') with the inner detail action ('AVATAR_REMOVED') to maintain clarity in log semantics.
action: 'AVATAR_REMOVED',

@mdawoud27 mdawoud27 merged commit 119c882 into main Apr 18, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/175/activity_logs_team branch April 18, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Activity logs for the team controller

2 participants