Skip to content

feature/get-all-activity-logs#184

Merged
mdawoud27 merged 13 commits into
mainfrom
feature/183/get_all_activity_logs
Apr 19, 2025
Merged

feature/get-all-activity-logs#184
mdawoud27 merged 13 commits into
mainfrom
feature/183/get_all_activity_logs

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #183

@mdawoud27 mdawoud27 added the enhancement New feature or request label Apr 19, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 19, 2025 11:08
@mdawoud27 mdawoud27 self-assigned this Apr 19, 2025
@mdawoud27 mdawoud27 linked an issue Apr 19, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature to retrieve all activity logs for an organization. Key changes include:

  • Renaming the password field to newPassword in the reset password validation.
  • Adding a new route and controller for fetching activity logs.
  • Updating activity log creation in the authentication controller and documenting the new endpoint in the README.

Reviewed Changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/validations/auth.validations.js Updated field name to align with reset password schema requirements.
src/routes/activitylog.routes.js Added a new route to handle activity logs fetching.
src/index.js Integrated the new activity log route into the application.
src/controllers/auth.controller.js Updated activity log details and changed user id reference in logout.
src/controllers/activitylog.controller.js Implemented the controller to fetch and paginate activity logs.
README.md Documented the new endpoint for retrieving activity logs.
Files not reviewed (3)
  • prisma/migrations/20250419103629_add_cascade_delete_to_user/migration.sql: Language not supported
  • prisma/schema.prisma: Language not supported
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)

src/controllers/auth.controller.js:897

  • The removal of the detailed action (FIREBASE_SIGNUP/FIREBASE_SIGNIN) in the firebaseLogin method decreases logging granularity. If this change is unintentional, reintroducing the descriptive action may help to better trace firebase login activities.
details: {

Comment thread src/controllers/activitylog.controller.js Outdated
@mdawoud27 mdawoud27 merged commit 97a5207 into main Apr 19, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/183/get_all_activity_logs branch April 19, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Get all activity logs

2 participants