feature/get-all-activity-logs#184
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new feature to retrieve all activity logs for an organization. Key changes include:
- Renaming the password field to newPassword in the reset password validation.
- Adding a new route and controller for fetching activity logs.
- Updating activity log creation in the authentication controller and documenting the new endpoint in the README.
Reviewed Changes
Copilot reviewed 27 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/validations/auth.validations.js | Updated field name to align with reset password schema requirements. |
| src/routes/activitylog.routes.js | Added a new route to handle activity logs fetching. |
| src/index.js | Integrated the new activity log route into the application. |
| src/controllers/auth.controller.js | Updated activity log details and changed user id reference in logout. |
| src/controllers/activitylog.controller.js | Implemented the controller to fetch and paginate activity logs. |
| README.md | Documented the new endpoint for retrieving activity logs. |
Files not reviewed (3)
- prisma/migrations/20250419103629_add_cascade_delete_to_user/migration.sql: Language not supported
- prisma/schema.prisma: Language not supported
- src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)
src/controllers/auth.controller.js:897
- The removal of the detailed action (FIREBASE_SIGNUP/FIREBASE_SIGNIN) in the firebaseLogin method decreases logging granularity. If this change is unintentional, reintroducing the descriptive action may help to better trace firebase login activities.
details: {
…ial/server into feature/183/get_all_activity_logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #183