Feature/67/update a specific user#68
Merged
Merged
Conversation
| @@ -109,11 +39,105 @@ export const getUserById = async (req, res, next) => { | |||
| }); | |||
|
|
|||
| if (!user) { | |||
There was a problem hiding this comment.
The 'error' variable is not defined when no user is found, which can lead to a runtime error. Consider creating a new error instance with a descriptive message or returning a 404 response.
Suggested change
| if (!user) { | |
| if (!user) { | |
| const error = new Error('User not found'); | |
| error.status = 404; |
| updateData.lastName = value.lastName; | ||
| } | ||
| if (value.phoneNumber) { | ||
| updateData.phoneNumber = encrypt(value.phoneNumber); |
There was a problem hiding this comment.
The 'encrypt' function is used without being imported or defined in the file. Please import or otherwise define the 'encrypt' function to ensure correct encryption of phone number values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
[ x]\ Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #