Feat/81/create a department#93
Merged
Merged
Conversation
added 6 commits
April 7, 2025 01:08
Closed
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (2)
src/routes/department.routes.js:10
- The route path '/api/department/all' does not match the documented endpoint '/api/departments' in the department controller. Consider updating the route for consistency.
'/api/department/all',
src/controllers/user.controller.js:441
- The function 'deleteFromCloudinary' is used without being imported. Ensure that it is imported correctly to avoid runtime errors.
await deleteFromCloudinary(user.profilePic);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
This pull request introduces a new endpoint to retrieve all departments, along with the necessary middleware, routes, and documentation updates. The most important changes include adding the New Controller and Route:
Middleware:
Swagger Documentation:
Application Setup:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)
src/controllers/department.controller.js:5
- The documented route '/api/departments' does not match the implemented endpoint in the route file. Please update the documentation to reflect the correct endpoint.
* @route GET /api/departments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #81