Skip to content

fix/send-otp-after-creating-organization#96

Merged
mdawoud27 merged 4 commits into
mainfrom
fix/95/send_otp_after_creating_organization
Apr 7, 2025
Merged

fix/send-otp-after-creating-organization#96
mdawoud27 merged 4 commits into
mainfrom
fix/95/send_otp_after_creating_organization

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #95

@mdawoud27 mdawoud27 added the bug Something isn't working label Apr 7, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 7, 2025 10:28
@mdawoud27 mdawoud27 self-assigned this Apr 7, 2025
@mdawoud27 mdawoud27 linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (3)

src/controllers/organization.controller.js:150

  • If organization IDs are unique, consider using prisma.organization.findUnique instead of findFirst to improve clarity and efficiency.
const org = await prisma.organization.findFirst({

src/controllers/organization.controller.js:157

  • [nitpick] The error message has a grammatical issue; consider revising it to: 'Organization not found' or 'The organization was not found'.
message: 'This organization not found',

src/controllers/organization.controller.js:179

  • [nitpick] The email text contains a punctuation and grammar issue; consider updating it to 'Your verification code is: ${verificationOTP}. It will expire in 10 minutes.'
text: `Organization name: ${org.name}\nYour verification code is: ${verificationOTP}. will expire in 10 min`,

@mdawoud27 mdawoud27 merged commit 9304f3a into main Apr 7, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the fix/95/send_otp_after_creating_organization branch April 7, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX]: Send OTP again after creating new organization

2 participants