Skip to content

feat: normalize quadratic forms over separably closed fields - #4308

Merged
tauceti-review-bot[bot] merged 1 commit into
TauCetiProject:mainfrom
utensil:roadmap/spinrep-sepclosed-normalization
Aug 23, 2026
Merged

feat: normalize quadratic forms over separably closed fields#4308
tauceti-review-bot[bot] merged 1 commit into
TauCetiProject:mainfrom
utensil:roadmap/spinrep-sepclosed-normalization

Conversation

@utensil

@utensil utensil commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Roadmap: RepresentationTheory

Summary

Adds the quadratic-form normalization used by the Spin polarization construction.

  • Proves that a finite-dimensional nondegenerate form over a separably closed field is equivalent to the unit-weight sum of squares.
  • Reuses the generic result at both polarization normalization sites.

Roadmap target

Supplies the normalization step used by SpinRepresentations Layer 4.

Verification

Full gates, consumers, import probes, golf, and aggregate 2+1 pass at 089ed41e4926dc3115a30850e96b131d6a0d7443.

Scale and generality

Changes two files by +64/−28 lines. The theorem applies to finite-dimensional nondegenerate quadratic forms over separably closed fields with invertible 2.

Scope

  • Consumes: Mathlib’s sum-of-squares normalization and separably closed square roots.
  • Provides: the unit-weight normalization theorem.
  • Fits: removes duplicate normalization machinery from the Spin polarization constructor.
  • Boundary: split-model construction and odd-dimensional Clifford structure remain separate.

🤖 GPT-5.6 Sol high · local aggregate 2+1 fixed: attribution (1)

@tauceti-review-bot tauceti-review-bot Bot added awaiting-CI CI has not yet reported on the latest commit roadmap/RepresentationTheory PR declares the RepresentationTheory roadmap as its primary association awaiting-review CI is green; waiting for review verdicts and removed awaiting-CI CI has not yet reported on the latest commit labels Aug 23, 2026
@utensil
utensil marked this pull request as ready for review August 23, 2026 19:25
@tauceti-review-bot tauceti-review-bot Bot added review-in-progress A review is running on this exact commit right now and removed awaiting-review CI is green; waiting for review verdicts labels Aug 23, 2026
@CBirkbeck

Copy link
Copy Markdown
Contributor

AI review — approved

Each rubric is judged independently by multiple review agents; the PR merges only once every rubric is green — any rubric that is not green (changes requested, blocked, errored, stale, or not yet run) blocks the merge. See the rubrics.

rubric state judge summary
correctness approved codex/gpt-5.6-sol The normalization theorem faithfully follows from orthogonal diagonalization and the existence of square roots of nonzero weights over separably closed fields with characteristic different from two. Its two polarization uses preserve the original semantics.
reuse approved codex/gpt-5.6-sol The separably closed normalization is genuinely more general than Mathlib’s algebraically closed result, and the implementation reuses Mathlib’s weighted-sum equivalence and scaling combinator.
scope approved codex/gpt-5.6-sol This is a single-topic extraction of normalization machinery already present in the Spin polarization implementation, with direct use in the roadmap’s Layer 4 maximal-isotropic construction.
attribution approved codex/gpt-5.6-sol The new module explicitly credits both central Mathlib declarations whose normalization argument it adapts and identifies the relevant roadmap layer; no missing attribution was found.
api-design approved codex/gpt-5.6-sol The new canonical theorem exposes the normalization required by downstream Spin construction, while its proof-only isometry helper remains private. No obsolete, over-exposed, or insufficiently characterized public surface is introduced.
generality approved codex/gpt-5.6-sol The normalization theorem matches Mathlib’s natural finite-dimensional quadratic-form API and uses the assumptions required by the underlying orthogonal-basis classification and separably closed square-root result.
placement approved codex/gpt-5.6-sol The generic normalization theorem is correctly placed under LinearAlgebra/QuadraticForm, and its two focused Mathlib imports directly supply the separably closed and quadratic-isometry APIs it uses.
naming approved codex/gpt-5.6-sol The new public theorem follows the adjacent Mathlib precedent QuadraticForm.equivalent_weightedSumSquares_of_isAlgClosed, accurately describes its conclusion and hypothesis, and introduces no notation.
documentation approved codex/gpt-5.6-sol The new substantive module and its public theorem are documented accurately, with appropriate scope, purpose, and attribution.
proof-quality approved codex/gpt-5.6-sol The new normalization proof is concise, readable, and follows the established Mathlib construction without undocumented definitional-equality manipulation or brittle proof chains.

♻️ = approved on an earlier commit, re-run before merge.

Reviewing this diff at head 089ed41. rubrics @ f854a7e. Review spend: $1.42.

@tauceti-review-bot tauceti-review-bot Bot added ready-to-merge CI green and every rubric approved; ready to merge and removed review-in-progress A review is running on this exact commit right now labels Aug 23, 2026
@tauceti-review-bot
tauceti-review-bot Bot added this pull request to the merge queue Aug 23, 2026
@tauceti-review-bot
tauceti-review-bot Bot removed this pull request from the merge queue due to a manual request Aug 23, 2026
@tauceti-review-bot
tauceti-review-bot Bot added this pull request to the merge queue Aug 23, 2026
Merged via the queue into TauCetiProject:main with commit 7b72922 Aug 23, 2026
17 checks passed
@tauceti-review-bot tauceti-review-bot Bot removed the ready-to-merge CI green and every rubric approved; ready to merge label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roadmap/RepresentationTheory PR declares the RepresentationTheory roadmap as its primary association

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants