chore: require minato ~> 0.18 in the test profile - #172
Merged
Conversation
The old ~> 0.17 range still allowed 0.17.x, whose pools fill eagerly. kura starts a repo per test module, so that is the shape that exhausted a server during the swap. 0.18 defaults min_size to 1 and grows on demand.
🟢 Code Coverage — 92.4%2612 of 2826 lines covered. 🟡 ELP Lint — 1 warning4 diagnostics found. See job logs for details. ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the test-profile floor from
~> 0.17to~> 0.18.Resolution already picks the newest match, so in practice the suite has been running against 0.18.5 since it was published. What the change buys is the floor:
~> 0.17still permits 0.17.x, whose pools fill eagerly on start. kura starts a repo per test module, which is exactly the shape that exhausted a server during the original swap. 0.18 defaultsmin_sizeto 1.1411 tests, 0 failures.
One pre-existing flake, flagged not fixed.
kura_through_tests:setupintermittently aborts with{badmatch,{error,{socket,closed}}}when the full suite runs; it passes on its own. It is not from this change - pinning minato 0.17.0 and running the same suite gives worse results:Worth its own issue: a module's setup should not depend on what ran before it.