chore(deps): test against minato 1.0 - #175
Merged
Merged
Conversation
minato 1.0 makes the socket transport the default, which changes what kura's own suite runs over even though the dependency is test profile only. 1427 eunit and 127 ct against it, through `_checkouts`, before the pin moved.
🟢 Code Coverage — 92.4%2612 of 2826 lines covered. 🟡 ELP Lint — 1 warning4 diagnostics found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minato 1.0 makes the socket transport the default, so kura's own suite now runs over the socket NIFs rather than the inet driver even though the dependency is test profile only.
Verified against 1.0.1 from Hex: 1427 eunit, 127 ct.
rebar.lockis untouched on purpose - minato is a test-profile dep here and profile deps are not locked. The consumer that ships minato to users iskura_postgres, which has its own PR.