chore: minato 0.18.5 - #50
Merged
Merged
Conversation
Picks up the row decoding work, and raises the constraint from ~> 0.15 to ~> 0.18. The old range still resolved to a minato whose pools filled eagerly, which is the behaviour that exhausted a server during the swap; 0.18 defaults min_size to 1.
🟠 Code Coverage — 57.4%1015 of 1769 lines covered. 🟡 ELP Lint — 1 warning1 diagnostic found. See job logs for details. ℹ️ 11 OTP CVEs auto-ignored (already fixed in running version)These CVEs are patched in the installed OTP version but NVD data
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks minato at 0.18.5, up from 0.15.4, and raises the constraint from
~> 0.15to~> 0.18.The constraint matters as much as the lock here.
~> 0.15still allowed a minato whose pools filled eagerly on start, which is what exhausted a server during the original swap. 0.18 defaultsmin_sizeto 1 and grows on demand, so pinning the floor above it stops a fresh resolve reintroducing the problem.The version also brings the row-reading work: rows decoded as a run while the buffer is framed, a row copied once into the result rather than twice, and columns cut in a single binary match. 35% fewer reductions per 5000-row query.
82 eunit and 110 ct green. fmt, xref and dialyzer clean.
Unrelated, and flagged rather than touched:
elp eqwalize-allreports 220 errors on this branch and the same 220 on main, so it is pre-existing debt rather than anything this bump introduced.