chore: take every plugin from hex and drop the sbom fork - #51
Merged
Conversation
rebar3_audit came from a git clone, and rebar3_sbom from a fork pinned to a branch or a commit that matches no released version. Audit is on Hex, so it is taken from there; sbom is dropped and audit is enabled in CI instead.
🟠 Code Coverage — 57.4%1015 of 1769 lines covered. 🟡 ELP Lint — 1 warning1 diagnostic found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything the build pulls now comes from Hex, so this can be published without a git dependency in the way.
rebar3_auditmoves from a git clone onmainto the Hex package,~> 0.2rebar3_sbomis dropped. It was pinned to a fork branch, so it was never a released version anybody else could reproduce. Only audit is kept, and it is enabled in CI.rebar3_hexadded. shigoto had norebar3_hexplugin at all, sorebar3 hex publishhad nothing to run. This is the change that actually makes it publishable.enable-sbomandenable-sbom-scanoff,enable-auditonDependency scanning is not lost by dropping sbom:
rebar3 auditis the check that reports vulnerable dependencies, and it now runs here rather than being disabled.