chore: stop tracking generated documentation - #55
Merged
Conversation
ex_doc writes doc/, and three recent commits swept it into the repository because they staged everything. It is build output: it has no reviewable content, and a version bump rewrites every file, which was a thousand lines of noise in the last two dependency bumps. minato, kura and kura_postgres all ignore it. shigoto now does too.
🟠 Code Coverage — 57.4%1015 of 1769 lines covered. 🟡 ELP Lint — 1 warning1 diagnostic found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/is ex_doc output. It got committed by three recent PRs of mine (#52, #53, #54) that staged everything, and it should not have been - the directory did not exist before them.It is build output, not source:
v1.9.5->v1.9.6minato, kura and kura_postgres all have
doc/in.gitignoreand track zero files there. shigoto was the odd one out only because it lacked the line.Removes the 56 tracked files and adds the ignore entry.
rebar3 ex_docstill generates them locally, andrebar3 hex publishstill uploads the docs tarball - neither depends on them being in git.