chore(ci): bump erlang-ci to v2.1.7 - #59
Merged
Merged
Conversation
Picks up the ELP fixes in erlang-ci#71/#72/#73: the elp action resolves its binary from the release instead of a hardcoded OTP-major table, and compiles the test profile before linting so parse transforms from test-only deps resolve. Neither changes anything for shigoto today - it is on OTP 28, which the old table covered, and it has no test module pulling in a parse transform - but it stops the next OTP bump from silently disabling the ELP jobs. Verified before bumping that this does not turn the lint gate red: `elp lint` reports 0 errors under both the old default-profile compile and the new test-profile one (5 warnings either way). release.yml is byte-identical between v2.0.9 and v2.1.7, so both pins move together.
🟠 Code Coverage — 57.4%1015 of 1769 lines covered. 🟡 ELP Lint — 5 warnings5 diagnostics found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the ELP fixes from Taure/erlang-ci#71, #72 and #73.
Found while auditing whether shigoto's ELP settings matched reality after widgrensit/asobi#436. Short version: shigoto is fine and this is a clean bump - unlike Taure/kura#176, which needed test fixes to land alongside it.
What the bump changes
Verified before bumping
elp linton this tree: 0 errors under both the old default-profile compile and the new test-profile compile (5 warnings, unchanged either way). So the newer ELP that comes with v2.1.7 does not introduce findings here.rebar3 fmt --checkclean.release.ymlis byte-identical between v2.0.9 and v2.1.7, so both pins move together.Not in this PR
enable-elp-eqwalizestaysfalse: 220 errors on this tree. That is a real project, same shape as widgrensit/asobi#435 - worth its own issue if you want to chip at it.