Skip to content

debug: logger=debug + try/catch verify_signature #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taure merged 1 commit into from
May 24, 2026
Merged

debug: logger=debug + try/catch verify_signature #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/prod_sys.config.src
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{kernel, [
{logger_level, info},
{logger_level, debug},
{logger, [
{handler, default, logger_std_h, #{
formatter => {nova_jsonlogger, #{
Expand Down
18 changes: 17 additions & 1 deletion src/controllers/triagebot_webhook_controller.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,23 @@ github_event(Req) ->
EventType = cowboy_req:header(~"x-github-event", Req1, ~""),
Delivery = cowboy_req:header(~"x-github-delivery", Req1, ~""),
Secret = triagebot_config:webhook_secret(),
case gakudan_tickets_github:verify_signature(Secret, Sig, Body) of
Valid =
try
gakudan_tickets_github:verify_signature(Secret, Sig, Body)
catch
Class:Reason:Stack ->
?LOG_ERROR(#{
event => verify_signature_crashed,
class => Class,
reason => Reason,
stack => Stack,
sig_byte_size => byte_size(Sig),
secret_byte_size => byte_size(Secret),
body_byte_size => byte_size(Body)
}),
false
end,
case Valid of
false ->
?LOG_WARNING(#{
event => webhook_signature_invalid,
Expand Down
Loading