Skip to content

[fix/#169] 2차 QA 반영 - #170

Merged
sssthnnhee merged 4 commits into
release/1.0.0from
fix/#169
Sep 16, 2026
Merged

sssthnnhee merged 4 commits into
release/1.0.0from
fix/#169

Conversation

@sssthnnhee

Copy link
Copy Markdown
Contributor

🌳 작업한 브랜치

✅ 작업한 내용

행간 익스텐션을 만들고 필요한 부분에 적용합니다

// UILabel+.swfit

    func setLineHeightText(
        _ text: String,
        font: UIFont,
        lineHeightRatio: CGFloat
    ) {
        self.font = font

        let paragraphStyle = NSMutableParagraphStyle()
        paragraphStyle.minimumLineHeight = font.pointSize * lineHeightRatio
        paragraphStyle.maximumLineHeight = font.pointSize * lineHeightRatio

        attributedText = NSAttributedString(
            string: text,
            attributes: [
                .font: font,
                .foregroundColor: textColor as Any,
                .paragraphStyle: paragraphStyle
            ]
        )
    }

-->

설정 탭의 1:1 문의하기, 탈퇴하기, 운동 기록 탭 에러 모달
총 세 곳에 있었던 여러 줄 텍스트에 적용해두엇어엽

📷 Screenshots

문의하기 before after
화면
탈퇴하기 before after
화면

💬 To Reviewers

2차는 정말 거의 없엇네엽 ㅎㅎ
짱마듀가 잘햇다는 뜻이겟지///

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b4671f3c-2cb7-4afa-b9bb-1d8e66833230

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ser0kim

ser0kim commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

행간 익스텐션이라니!! 넘 고능하고 좋다. 이렇게 디자인 디테일까지 다 구현해나가는 짱마듀 🫶 최고마듀!! 고생했어요오

@sangyup12 sangyup12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디테일까지 챙겨주시다니 고생많으셨습니다!!

@sssthnnhee sssthnnhee self-assigned this Sep 15, 2026
@sssthnnhee sssthnnhee added 🩹 Fix 버그나 오류 해결 ⛰️ seunghee 이승희올시다 labels Sep 15, 2026
@sssthnnhee
sssthnnhee merged commit 1402792 into release/1.0.0 Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🩹 Fix 버그나 오류 해결 ⛰️ seunghee 이승희올시다

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants