[YouTube] Fix signature deobfuscation function name extraction #1290

FineFindus · 2025-03-31T13:54:42Z

Adds a new regex to find the signature deobfuscation function that works for the new 20830619 player. The regex is taken from #1287 (comment), I suspect it originated from yt-dlp, as they use an almost identical one.

Closes: #1287
Ref: #1287 (comment)

I carefully read the contribution guidelines and agree to them.
I have tested the API against NewPipe.
I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

AlternativeOne · 2025-04-08T13:49:15Z

At this point of time, I think, it makes sense to think about separating this "deobfuscation function name extraction" part of code (or even some more) into some form that could be easily updated without updating the app.

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now it just contains a fix for working with newer YT player versions and checks if a video is avialable. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube#7113

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor Co-authored-by: reocat <[email protected]>

gechoto · 2025-04-15T14:59:18Z

Hi @FineFindus thanks for working on this.
Do you also plan to incorporate a fix for #1289 in your fork?

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor

FineFindus · 2025-04-15T17:55:28Z

Do you also plan to incorporate a fix for #1289 in your fork?

Not unless there is a corresponding PR here, but I'm also not aware of any fix.

gechoto · 2025-04-20T01:23:05Z

Not unless there is a corresponding PR here, but I'm also not aware of any fix.

yt-dlp has it working but it still needs to be ported to NewPipeExtractor

Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor

FineFindus · 2025-04-25T20:29:42Z

I won't stop you from porting it :)

AudricV

This doesn't work anymore, YouTube has changed again its code. Could you please update the regular expression you added to support latest YouTube JavaScript code?

FineFindus · 2025-05-26T19:42:46Z

With the players I'm getting, this still finds the correct function, however the function structure itself has changed and now also relies on a global variable. Implemented support for it in 60d3b71.

Updates the NewPipeExtractor to the lastest version of our fork to include the improvements to the signature and throttling issues. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: TeamNewPipe/NewPipeExtractor#1302

litetex

Currently not working:

Failed to find pattern "(var [A-Z]='.*'.split\(";"\))"
org.schabi.newpipe.extractor.utils.Parser$RegexException: Failed to find pattern "(var [A-Z]='.*'.split\(";"\))"
	at app//org.schabi.newpipe.extractor.utils.Parser.matchGroup(Parser.java:73)
	at app//org.schabi.newpipe.extractor.utils.Parser.matchGroup(Parser.java:60)
	at app//org.schabi.newpipe.extractor.utils.Parser.matchGroup1(Parser.java:49)
	at app//org.schabi.newpipe.extractor.services.youtube.YoutubeSignatureUtils.getDeobfuscationCode(YoutubeSignatureUtils.java:95)
	at app//org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptPlayerManager.deobfuscateSignature(YoutubeJavaScriptPlayerManager.java:145)
	at app//org.schabi.newpipe.extractor.services.youtube.YoutubeSignaturesTest.testSignatureDeobfuscation(YoutubeSignaturesTest.java:54)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.Optional.ifPresent(Optional.java:178)

Adds a new regex to find the signature deobfuscation function, which works for the new `20830619` player. Closes: TeamNewPipe#1287 Ref: TeamNewPipe#1287 (comment)

Extracts the global variable used in newer signature deobfuscation functions, such as the one found in the `59b252b9` player.

FineFindus · 2025-07-11T06:34:27Z

Looks like the use allow case letters and single quotes now. Should now work again.

Outdated

litetex

LGTM, I will update the mocks and then we can merge this :)

AudricV added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Mar 31, 2025

FineFindus force-pushed the fix/deobfuscation-function branch from 92cd0b0 to 0e54ccb Compare April 5, 2025 06:22

AudricV changed the title ~~[YouTube] add new deobfuscation function regex~~ [YouTube] Fix deobfuscation function name extraction Apr 5, 2025

m-obeid mentioned this pull request Apr 6, 2025

PlaybackException: This video is private / this video is inappropriate for some users OuterTune/OuterTune#476

Closed

FineFindus mentioned this pull request Apr 9, 2025

build: use NewPipeExtractor fork libre-tube/LibreTube#7293

Merged

anxiouslelimo mentioned this pull request Apr 14, 2025

music stoping at second 30!!!! mostafaalagamy/Metrolist#524

Closed

4 tasks

ShareASmile added the ready for review Most of the work is done, PR is now ready for a review label Apr 16, 2025

knighthat mentioned this pull request May 6, 2025

Stopping after 1 min (more or less) using 4G knighthat/Kreate#204

Closed

3 tasks

TacoMagick approved these changes May 10, 2025

View reviewed changes

VVispy mentioned this pull request May 22, 2025

Error 2004/403 fix? OuterTune/OuterTune#604

Closed

AudricV previously requested changes May 24, 2025

View reviewed changes

AudricV removed the ready for review Most of the work is done, PR is now ready for a review label May 24, 2025

MetalDroid mentioned this pull request May 25, 2025

Fix Android client; Prioritize clients that usually work mostafaalagamy/Metrolist#707

Merged

FineFindus force-pushed the fix/deobfuscation-function branch from 0e54ccb to 60d3b71 Compare May 26, 2025 19:42

FineFindus force-pushed the fix/deobfuscation-function branch from 60d3b71 to 04deb5d Compare May 27, 2025 06:06

FineFindus mentioned this pull request May 27, 2025

build: update NewPipeExtractor libre-tube/LibreTube#7458

Merged

AudricV changed the title ~~[YouTube] Fix deobfuscation function name extraction~~ [YouTube] Fix signature deobfuscation function name extraction Jun 1, 2025

litetex previously requested changes Jul 10, 2025

View reviewed changes

FineFindus added 4 commits July 11, 2025 08:27

[YouTube] add new signature regex

235dd7c

Adds a new regex to find the signature deobfuscation function, which works for the new `20830619` player. Closes: TeamNewPipe#1287 Ref: TeamNewPipe#1287 (comment)

[YouTube] extract global variable for signature deobfuscation

d914e86

Extracts the global variable used in newer signature deobfuscation functions, such as the one found in the `59b252b9` player.

[YouTube] Allow lowercase global array names

a847fdb

[YouTube] Allow both types of string quotes

1915dc6

FineFindus force-pushed the fix/deobfuscation-function branch from 04deb5d to 1915dc6 Compare July 11, 2025 06:28

litetex approved these changes Jul 11, 2025

View reviewed changes

Updated mocks

249f8f8

litetex merged commit ebb53fb into TeamNewPipe:dev Jul 11, 2025
3 checks passed

FineFindus deleted the fix/deobfuscation-function branch July 11, 2025 18:42

litetex mentioned this pull request Jul 17, 2025

Throttling/n-parameter deobfuscation not working #1339

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[YouTube] Fix signature deobfuscation function name extraction #1290

[YouTube] Fix signature deobfuscation function name extraction #1290

Uh oh!

FineFindus commented Mar 31, 2025

Uh oh!

AlternativeOne commented Apr 8, 2025

Uh oh!

gechoto commented Apr 15, 2025 •

edited

Loading

Uh oh!

FineFindus commented Apr 15, 2025

Uh oh!

gechoto commented Apr 20, 2025

Uh oh!

FineFindus commented Apr 25, 2025

Uh oh!

AudricV left a comment

Uh oh!

FineFindus commented May 26, 2025

Uh oh!

litetex left a comment

Uh oh!

FineFindus commented Jul 11, 2025

Uh oh!

litetex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[YouTube] Fix signature deobfuscation function name extraction #1290

[YouTube] Fix signature deobfuscation function name extraction #1290

Uh oh!

Conversation

FineFindus commented Mar 31, 2025

Uh oh!

AlternativeOne commented Apr 8, 2025

Uh oh!

gechoto commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FineFindus commented Apr 15, 2025

Uh oh!

gechoto commented Apr 20, 2025

Uh oh!

FineFindus commented Apr 25, 2025

Uh oh!

AudricV left a comment

Choose a reason for hiding this comment

Uh oh!

FineFindus commented May 26, 2025

Uh oh!

litetex left a comment

Choose a reason for hiding this comment

Uh oh!

FineFindus commented Jul 11, 2025

Uh oh!

litetex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gechoto commented Apr 15, 2025 •

edited

Loading