Skip to content

Make Singleton.OnDestroy virtual #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XuuXiaolan merged 1 commit into from
Feb 5, 2026
Merged

Make Singleton.OnDestroy virtual #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DawnLib.Dusk/src/API/Definitions/Achievements/AchievementUI/AchievementUIGetCanvas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ private void Start()
DuskAchievementHandler.OnAchievementUnlocked += QueuePopup;
}

private void OnDestroy()
protected override void OnDestroy()
{
DuskAchievementHandler.OnAchievementUnlocked -= QueuePopup;
base.OnDestroy();
}

internal void QueuePopup(DuskAchievementDefinition achievement)
Expand Down
2 changes: 1 addition & 1 deletion DawnLib/src/Utils/Singleton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static T? Instance
}
}

protected void OnDestroy()
protected virtual void OnDestroy()
{
if (Instance == (T)this) _instance = null;
}
Expand Down
Loading