-
Notifications
You must be signed in to change notification settings - Fork 5
ci: add smoke test script, Makefile target, and CI workflow; README b… #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive testing infrastructure to the project, including a smoke test script for end-to-end validation, build automation, and continuous integration. The smoke test validates the HTTP server startup, health endpoint, and CLI functionality.
- Adds a smoke test script that validates server startup and basic functionality
- Integrates smoke testing into the build system via Makefile
- Sets up GitHub Actions CI workflow for automated testing
- Adds CI status badge to README
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
scripts/smoke.sh | New smoke test script that starts the HTTP server and validates basic functionality |
README.md | Adds CI status badge |
Makefile | Adds smoke test target |
.github/workflows/ci.yml | New CI workflow with build, unit tests, and smoke tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
if ! lsof -ti tcp:"${PORT}" >/dev/null 2>&1; then | ||
echo "[smoke] server failed to start; logs:" >&2 | ||
sed -n '1,200p' "${LOGFILE}" >&2 || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The magic number '200' is duplicated. Consider defining a constant like MAX_LOG_LINES=200 at the top of the script to improve maintainability.
Copilot uses AI. Check for mistakes.
Hi, thanks for the contribution! From what I can see, this only starts the MCP HTTP server and checks if the health endpoint is running. 🤔 Could we add it as part of the existing test suite? mcp/.github/workflows/test.yaml Lines 57 to 75 in d2691b7
A new |
…adge
Description
Type of Change
Testing
go test -v ./...
)Checklist