Add OnExec() #14
Open
Add OnExec() #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syscall.Exec() will unapologetically replace/kill the current process. This is good in many cases, but in some cases you really want to run some code before it does so. In my case, the Go backend also starts a webpack nodejs process to rebuild the frontend on changes, but the node process will keep running as an orphan because the parent died. With OnExec() the parent can instruct the children to kill themselves. There are probably some other use cases as well. It would be nicer to add this to reload.Do(), but we can't really do that without an incompatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscall.Exec() will unapologetically replace/kill the current process. This is good in many cases, but in some cases you really want to run some code before it does so.
In my case, the Go backend also starts a webpack nodejs process to rebuild the frontend on changes, but the node process will keep running as an orphan because the parent died. With OnExec() the parent can instruct the children to kill themselves. There are probably some other use cases as well.
It would be nicer to add this to reload.Do(), but we can't really do that without an incompatible change.