Ios 9356 rename crouton to snackbar #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
reviewed
Feb 20, 2025
| import UIKit | ||
|
|
||
| // Protocol implemented by view controllers that want to Snackbar in a very specific view | ||
| @objc public protocol CustomSnackbarContainer { |
There was a problem hiding this comment.
new??? in that case, remove @objc pls
There was a problem hiding this comment.
Just moved and renamed the file, no logic changes in this PR.
File in main:
`
import UIKit
// Protocol implemented by view controllers that want to show croutons in a very specific view
@objc public protocol CustomCroutonContainer {
var customCroutonContainerView: UIView { get }
}
`
amegias
reviewed
Feb 20, 2025
|
|
||
| | `Info` | `Critical` | | ||
| |-----------------------------------------------|---------------------------------------------------| | ||
| |  |  | |
| @@ -20,29 +20,29 @@ public class CroutonController: NSObject { | |||
| public typealias DismissHandlerBlock = (SnackbarDismissReason) -> Void | |||
| public typealias DidTapActionBlock = () -> Void | |||
|
|
|||
| private var croutonViewList = [OngoingCrouton]() | |||
| private var SnackbarViewList = [OngoingSnackbar]() | |||
There was a problem hiding this comment.
Suggested change
| private var SnackbarViewList = [OngoingSnackbar]() | |
| private var snackbarViewList = [OngoingSnackbar]() |
amegias
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-9356
🥅 What's the goal?
Rename Crouton component to Snackbar
🚧 How do we do it?
Rename the component.
Update readme.
:
🧪 How can I verify this?
Catalog -> snackbar
snackbar.mov
🏑 AppCenter build