Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化Hippy生成的前端包体机大小 #3983

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

优化Hippy生成的前端包体机大小 #3983

wants to merge 5 commits into from
+193 −160

Conversation

yokots
Copy link

@yokots yokots commented Aug 6, 2024

just see each commit message.

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@yokots
chore(drive/js): bump up ttypescript version
da02a90 
Current ttypescript version not support node v16.20.2, the latest v16 version.
It will cause this issue: cevek/ttypescript#150
@yokots
fix(hipp-vue-next): correct patchProps types
3099f36 
align patchProps types with vue runtime core, but
there also have some spec tests to fix
@yokots
refactor(vue-next): minify generated style code
19ba82d 
just like fromSsrAstNodes, optimize the output in hippy-vue-css-loader,
and make hippy-vue-next-style-parser to compatible with old and new format.
@yokots
build(example-scripts): remove webpack.NamedModulesPlugin
0648431 
webpack.NamedModulesPlugin was deprecated in v4 and removed in v5.
these plugin are default in devlopment mode and should not be configured in production mode,
because it will expose file path and increase bundle sizes.

https://v4.webpack.js.org/migrate/4/#deprecatedremoved-plugins
@yokots
chore(examples): update vue3 assets
af3347d
@github-actions github-actions bot added driver: js doc: example framework: voltron size: m Denotes a PR that changes 100-499 lines labels Aug 6, 2024
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 6, 2024

Hi, @yokots. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 6, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 Awaiting requested review from zealotchen0 zealotchen0 is a code owner

@lvfen lvfen Awaiting requested review from lvfen lvfen is a code owner

@henryjin0511 henryjin0511 Awaiting requested review from henryjin0511 henryjin0511 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc: example driver: js framework: voltron size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokots @tencent-adm