Repository navigation
fix: allow editing saved hosts with string IDs - #60
Merged
LukeGus merged 1 commit intoNov 7, 2026
Merged
Conversation
|
AI review | Looks safe to merge The change parses string host IDs from the shell into numbers to enable the edit host action for saved hosts, while safely rejecting invalid or quick-connect identifiers. No security or stability risks are present. Reviewed c2e8433. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminal's failure-screen Edit host action only accepts numeric host IDs, but the shell supplies saved host IDs as strings. This hides the action for valid saved hosts even when the shell supports editing.
Accept positive decimal safe-integer IDs in either representation and pass a numeric ID to the existing editor. Quick-connect and malformed IDs remain excluded, and older shells without the editing capability still hide the action.
Related: #36. The global shell bridge also needs the companion core fix (Termix-SSH/Termix#1778) to expose its existing editHost callback; this plugin change fixes the separate ID gate.
Validation: regression tests failed on the original implementation for saved string IDs and invalid numeric IDs. Fresh npm ci, all 651 tests, typecheck, build, manifest validation, pack and formatting passed. The SDK lockfile is synchronized with its existing declaration. Native macOS desktop acceptance has not been performed.