-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client version in cluster state dumps. #312
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to this change, we'll be able to track clients version using the MnM stack; since the serial ID did not change, I'll make sure other PRs are version proof catching proper exceptions when deserializing
@myronkscott can you please add your review ? thanks |
I have a concern that in rare cases, this change may crash the cluster. If a stripe split-brains, then heals, the active will as the other active for information that includes this serialized object. I know it is not a great solution, but maybe we should include version information as part of the UUID. |
I think the best way to handle this is to add a new sub-class of PlatformConnectedClient which includes the version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a new subclass rather than modifying the existing one.
hello, @myronkscott do you want me or @GaryWKeim to add this new subclass ? |
I think we need to discuss. Even a subclass is bad as a legacy server will not have the sub-class and cause problems. |
Terracotta-OSS/terracotta-platform#540
Terracotta-OSS/terracotta-core#1044