Add tournament status and mode filters to GET /api/tournaments#345
Open
Stanley-Owoh wants to merge 15 commits into
Open
Conversation
- Add tournamentListQuerySchema with status and mode enum validation - Apply Zod-validated query params to filter mock data server-side - Document query params in README with curl examples
…t-api-tournaments-330
…ctions and missing entries
…-and-mode-filters-to-get-api-tournaments-330
…t-api-tournaments-330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
statusandmodequery param filters toGET /api/tournamentsso the frontend can render tournament tabs without client-side filtering.Changes
src/schemas/tournament.schema.tstournamentListQuerySchema— extends the existingoffsetPaginationSchemawith two optional enum fields:status:UPCOMING | ACTIVE | COMPLETEDmode:UP_DOWN | LEGENDSTournamentListQuerytypesrc/routes/tournaments.routes.tsvalidate(offsetPaginationSchema, "query")withvalidate(tournamentListQuerySchema, "query")on the list endpointstatusandmodefrom the validated querytoUpperCase()case-insensitive status filter (validation is now strict through Zod)README.mdAcceptance Criteria
?status=ACTIVEreturns only active tournaments?mode=LEGENDSreturns only legends-mode tournaments?status=UPCOMING&mode=LEGENDScombines both filters?status=INVALIDreturns 400Closes #330