Skip to content

Additional LPM documentation updates #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Additional LPM documentation updates #259

merged 3 commits into from
Apr 9, 2025

Conversation

kwillis01
Copy link
Contributor

@kwillis01 kwillis01 commented Apr 7, 2025 •
edited
Loading

Documentation updates to address comments from Akash's comments from this PR #245

Updates include:

  • Updating the confirmation of wakeup events to include the pin that caused the wakeup and the last entered low power mode.
  • Increasing readability for setting CPU resume constraints where the resume latency is referenced in ms and not us

@kwillis01
Copy link
Contributor Author

@akashdeep-ti I do not really understand your comment here: #245 (comment)
To my understanding it is still valid to keep this as an example because it is in the code for when a timeout happens with setting the completion of suspend on rproc.

StaticRocket
StaticRocket previously approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the note is a little redundant considering the sysfs entry is suffixed with _us but this is fine.

@StaticRocket
Copy link
Member

Also, thanks for using the proper tags for these commits. In the future you can shorten this by just saying something like:

fix(power-management): Increase readibility for resume latency

Which now that I'm typing this out, there's a typo in that subject.

@akashdeep-ti
Copy link
Contributor

@akashdeep-ti I do not really understand your comment here: #245 (comment) To my understanding it is still valid to keep this as an example because it is in the code for when a timeout happens with setting the completion of suspend on rproc.

This is not valid as at this stage, the prepare sleep has been sent to DM and even if we set constraints, DM will not honour that

@kwillis01
Copy link
Contributor Author

@akashdeep-ti I do not really understand your comment here: #245 (comment) To my understanding it is still valid to keep this as an example because it is in the code for when a timeout happens with setting the completion of suspend on rproc.

This is not valid as at this stage, the prepare sleep has been sent to DM and even if we set constraints, DM will not honour that

ahh i see, i will take this out then

kwillis01 added 3 commits April 8, 2025 08:48
@kwillis01
fix(power-management): Increase readability for resume latency
cf83b7a 
Change units from us to ms when referencing CPU resume latency in order
to increase readability from user. Referring to  resume latency in ms is
inline with the TI SCI documentation for setting resume latency.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
feat(power-management): Add confirmation of wakeup pin and mode
4e73bc5 
When the SoC resumes in SDK 11.00 the pin that caused the wakeup event
and the low power mode last entered are printed upon resume of the
system. Explain how to find what wakeup event is associated with the pin
printed and what low power mode was entered. Add an example of finding
this.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
fix(power-management): Remove remoteproc device constraint example
862ba85 
Remove the example of how to set a device constraint that leaves the
device powered on. This example references the remoteproc driver. In
this driver, the constraint is being set during suspend_late. At that
point in the suspend sequence, no new constraints are being sent to the
DM so this code does not show a device constraint being set correctly.

Signed-off-by: Kendall Willis <[email protected]>
@cshilwant
Copy link
Member

@akashdeep-ti to re-review

@praneethbajjuri praneethbajjuri merged commit a5bec67 into TexasInstruments:master Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praneethbajjuri praneethbajjuri praneethbajjuri approved these changes

@cshilwant cshilwant cshilwant approved these changes

@StaticRocket StaticRocket StaticRocket left review comments

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

@aniket-l aniket-l Awaiting requested review from aniket-l aniket-l is a code owner

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@devarsht devarsht Awaiting requested review from devarsht

@DhruvaG2000 DhruvaG2000 Awaiting requested review from DhruvaG2000

@r-vignesh r-vignesh Awaiting requested review from r-vignesh

+1 more reviewer

@vishalmti vishalmti vishalmti approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@DhruvaG2000 DhruvaG2000

@uditkumarti uditkumarti

@vishalmti vishalmti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kwillis01 @StaticRocket @akashdeep-ti @cshilwant @praneethbajjuri @vishalmti @devarsht @r-vignesh @DhruvaG2000 @uditkumarti