Skip to content

source: devices: J7_family: Update performance numbers for ALSA #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

jayesh-ti
Copy link
Contributor

Add performance numbers for Audio playback and Audio capture for J742S2.

Playback logs: https://gist.github.com/jayesh-ti/e1b25d6163dcbe1d3a6224530c006c5a
Capture logs: https://gist.github.com/jayesh-ti/7820d7c5700fb4f31d71930195d8e91c

Copy link

New warnings found with rstcheck:

source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:475: (ERROR/3) Error with CSV data in "csv-table" directive:
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:792: (INFO/1) Duplicate implicit target name: "j721e-idk-gw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:826: (INFO/1) Duplicate implicit target name: "ubifs".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:840: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:858: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:875: (INFO/1) Duplicate implicit target name: "ubifs".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:889: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:905: (INFO/1) Duplicate implicit target name: "ubifs".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:919: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:937: (INFO/1) Duplicate implicit target name: "ubifs".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:951: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:968: (INFO/1) Duplicate implicit target name: "ubifs".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:982: (INFO/1) Duplicate implicit target name: "raw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1018: (INFO/1) Duplicate implicit target name: "j721e-idk-gw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1036: (INFO/1) Duplicate implicit target name: "j721s2-evm".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1050: (INFO/1) Duplicate implicit target name: "j784s4-evm".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1064: (INFO/1) Duplicate implicit target name: "j742s2-evm".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1108: (INFO/1) Duplicate implicit target name: "j721e-idk-gw".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1125: (INFO/1) Duplicate implicit target name: "j784s4-evm".
source/devices/J7_Family/linux/_Release_Specific_Kernel_Performance_Guide.rst:1138: (INFO/1) Duplicate implicit target name: "j742s2-evm".

@cshilwant
Copy link
Member

The failing job "Commit Check" rejected a commit due to a violation of the conventional commit message format. The error indicates that the commit message did not align with the required conventions.

Solution:

  1. Fix the Commit Message:
    Ensure the commit message follows the Conventional Commits format. For example:

    feat(devices): update performance numbers for ALSA on J7 family
    

    This format includes:

    • A type (feat, fix, docs, etc.)
    • A scope (optional, e.g., devices)
    • A concise description.
  2. Amend the Commit:

  3. Rerun the Workflow:
    After amending and force-pushing the commit, GitHub Actions will automatically rerun the workflow.

No changes are required to the workflow file (commit-check.yml), as the configuration enforces the correct commit message format.


Time to make Copilot as default reviewer.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"44100","1411171.00","0.54","1417793.00","0.96","1327227.00","0.63","1417810.00","0.18","1417812.00","0.43"
"48000","1535969.00","0.75","1535955.00","0.97","1535909.00","0.66","1535967.00","0.14","1535969.00","0.29"
"88200","2822343.00","0.93","2835618.00","1.44","2654473.00","1.00","2835634.00","0.32","2835638.00","0.67"
"96000","3071938.00","0.50","3071926.00","1.52","3071829.00","1.05","3071939.00","0.20","3071945.00".,"0.40"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without completely parsing this I assume this is the issue the linter is upset about.

Suggested change
"96000","3071938.00","0.50","3071926.00","1.52","3071829.00","1.05","3071939.00","0.20","3071945.00".,"0.40"
"96000","3071938.00","0.50","3071926.00","1.52","3071829.00","1.05","3071939.00","0.20","3071945.00","0.40"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants