Fix/issue 3871 table padding #3900
Open
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _get_padding_width() method was not considering the pad_edge setting, causing inconsistency between width calculation and actual rendering. When pad_edge=False, the first column was sized with full padding but rendered without left padding, resulting in misaligned tables. This fix adds pad_edge logic to _get_padding_width() to ensure consistency between measurement and rendering. Changes: - Updated _get_padding_width() to respect pad_edge setting - Added logic to exclude left padding for first column when pad_edge=False - Added logic to exclude right padding for last column when pad_edge=False - Updated test_columns.py expected output to reflect corrected behavior Fixes Textualize#3871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
The
_get_padding_width()method was not considering thepad_edgesetting when calculating column widths. This caused inconsistency between:pad_edge=FalseThis resulted in the first column being sized larger than necessary, causing misalignment.
Changes
_get_padding_width()methodTesting
Manual test with issue example passes
All table/column tests pass
Note on Pre-existing Test Failures
The following 4 tests were already failing (locally) before this fix:
tests/test_log.py::test_logtests/test_markdown.py::test_inline_codetests/test_syntax.py::test_blank_linestests/test_syntax.py::test_python_render_simple_indent_guidesThese are unrelated to this change.
Impact
Table.grid()renderingColumnslayout (usesTable.grid()internally)