Update hw_getfile.cpp #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In your while-loop, you need to check that `pos` is not -1. -1 means that the substring (`word` in this case) was not found on that line. ANY positive integer means that `word` was found and thus is a match. So you only need to test `pos` against the value -1. I also put in a check for the number of arguments given. If somebody runs your program without arguments, you should give a helpful error message and exit non-zero. Without that check, your program was simply illegally accessing the array `argv` and being killed by the system for an "out of bounds" exception. A quick check against `argc` makes this common situation much prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your while-loop, you need to check that
posis not -1. -1 means that the substring (wordin this case) was not found on that line. ANY positive integer means thatwordwas found and thus is a match. So you only need to testposagainst the value -1.I also put in a check for the number of arguments given. If somebody runs your program without arguments, you should give a helpful error message and exit non-zero. Without that check, your program was simply illegally accessing the array
argvand being killed by the system for an "out of bounds" exception. A quick check againstargcmakes this common situation much prettier.