feat(assets): 使用 npm 管理前端外部依赖#212
Draft
ThaddeusJiang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/package.json和assets/package-lock.json管理。assets/vendor中复制的外部依赖源码,并更新 CSS/JS import。esbuild在 Mix/Hex 依赖中管理。Why
Validation
MIX_DEPS_PATH=deps mix format --check-formattedMIX_DEPS_PATH=deps mix compile --warnings-as-errorsDATABASE_URL=postgres://postgres:postgres@localhost:20001/vmemo_test TYPESENSE_URL=http://localhost:20002 TYPESENSE_API_KEY=xyz MIX_DEPS_PATH=deps mix test test/vmemo/assets_pipeline_test.exsnpm run build --prefix assetsMIX_DEPS_PATH=deps mix assets.deploygit diff --checkRelated
Notes
phoenix、phoenix_html、phoenix_live_view不进入 npm。esbuild不进入 npm,继续使用 Mix/Hex wrapper。MIX_DEPS_PATH,验证时显式使用MIX_DEPS_PATH=deps以避免读到旧编译产物。