bazel: drop readline dependency from abc#10530
Closed
maliberty wants to merge 1 commit into
Closed
Conversation
The abc BCR overlay BUILD unconditionally wires @readline into the abc cc_library and sets ABC_USE_READLINE. OpenROAD drives abc programmatically and does not need the interactive line editor, so add a single_version_override that patches both out. Temporary until bazelbuild/bazel-central-registry#9021 is merged. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the dependency on readline from the abc module. It introduces a new patch file bazel/abc_no_readline.patch that removes the ABC_USE_READLINE definition and the @readline dependency from the abc build configuration, and configures a single_version_override in MODULE.bazel to apply this patch. The MODULE.bazel.lock file has been updated accordingly. There are no review comments, so I have no feedback to provide.
Member
Author
|
already moot |
Collaborator
|
@maliberty How did this get resolved? (since it is moot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abc BCR overlay BUILD unconditionally wires @readline into the abc cc_library and sets ABC_USE_READLINE. OpenROAD drives abc programmatically and does not need the interactive line editor, so add a single_version_override that patches both out.
Temporary until bazelbuild/bazel-central-registry#9021 is merged.