Skip to content

gui: fix bbox descriptor #10575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LucasYuki wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −26
Draft

gui: fix bbox descriptor #10575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c2c00
gui: getBBox descriptors check if bbox is inverted
LucasYuki May 21, 2026
f854477
Update src/odb/src/db/dbITerm.cpp
LucasYuki Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions src/gui/src/dbDescriptors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ bool DbMasterDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
auto master = std::any_cast<odb::dbMaster*>(object);
master->getPlacementBoundary(bbox);
return true;
return !bbox.isInverted();
}

void DbMasterDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -1014,20 +1014,17 @@ bool DbNetDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
auto net = getObject(object);
auto wire = net->getWire();
bool has_box = false;
bbox.mergeInit();
if (wire) {
const auto opt_bbox = wire->getBBox();
if (opt_bbox) {
bbox.merge(opt_bbox.value());
has_box = true;
}
}
if (!has_box) {
if (bbox.isInverted()) {
// a wire bbox was not found, try using guides
for (odb::dbGuide* guide : net->getGuides()) {
bbox.merge(guide->getBox());
has_box = true;
}
}

Expand All @@ -1036,17 +1033,15 @@ bool DbNetDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
continue;
}
bbox.merge(inst_term->getBBox());
has_box = true;
}

for (auto blk_term : net->getBTerms()) {
for (auto pin : blk_term->getBPins()) {
bbox.merge(pin->getBBox());
has_box = true;
}
}

return has_box;
return !bbox.isInverted();
}

void DbNetDescriptor::findSourcesAndSinks(
Expand Down Expand Up @@ -2163,7 +2158,7 @@ bool DbITermDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
auto iterm = std::any_cast<odb::dbITerm*>(object);
if (iterm->getInst()->getPlacementStatus().isPlaced()) {
bbox = iterm->getBBox();
return true;
return !bbox.isInverted();
}
return false;
}
Expand Down Expand Up @@ -2500,7 +2495,7 @@ bool DbMTermDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
auto mterm = std::any_cast<odb::dbMTerm*>(object);
bbox = mterm->getBBox();
return true;
return !bbox.isInverted();
}

void DbMTermDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -2744,7 +2739,7 @@ bool DbBlockageDescriptor::getBBox(const std::any& object,
auto* blockage = std::any_cast<odb::dbBlockage*>(object);
odb::dbBox* box = blockage->getBBox();
bbox = box->getBox();
return true;
return !bbox.isInverted();
}

void DbBlockageDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -2861,7 +2856,7 @@ bool DbObstructionDescriptor::getBBox(const std::any& object,
auto obs = std::any_cast<odb::dbObstruction*>(object);
odb::dbBox* box = obs->getBBox();
bbox = box->getBox();
return true;
return !bbox.isInverted();
}

void DbObstructionDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -3301,7 +3296,7 @@ bool DbTermAccessPointDescriptor::getBBox(const std::any& object,
xform.apply(pt);
}
bbox = {pt, pt};
return true;
return !bbox.isInverted();
}

void DbTermAccessPointDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -3440,7 +3435,7 @@ bool DbGroupDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
auto* region = group->getRegion();
if (region != nullptr && region->getBoundaries().size() == 1) {
bbox = region->getBoundaries().begin()->getBox();
return true;
return !bbox.isInverted();
}
return false;
}
Expand Down Expand Up @@ -3552,7 +3547,7 @@ bool DbRegionDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
odb::Rect box_rect = box->getBox();
bbox.merge(box_rect);
}
return true;
return !bbox.isInverted();
}

void DbRegionDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -4765,7 +4760,7 @@ bool DbSiteDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
if (isSpecificSite(object)) {
bbox = getRect(object);
return true;
return !bbox.isInverted();
}

return false;
Expand Down Expand Up @@ -4908,7 +4903,7 @@ bool DbRowDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
auto* row = std::any_cast<odb::dbRow*>(object);
bbox = row->getBBox();
return true;
return !bbox.isInverted();
}

void DbRowDescriptor::highlight(const std::any& object, Painter& painter) const
Expand Down Expand Up @@ -4973,12 +4968,10 @@ bool DbMarkerCategoryDescriptor::getBBox(const std::any& object,
{
auto* category = std::any_cast<odb::dbMarkerCategory*>(object);
bbox.mergeInit();
bool has_bbox = false;
for (odb::dbMarker* marker : category->getAllMarkers()) {
bbox.merge(marker->getBBox());
has_bbox = true;
}
return has_bbox;
return !bbox.isInverted();
}

void DbMarkerCategoryDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -5073,7 +5066,7 @@ bool DbMarkerDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
auto* marker = std::any_cast<odb::dbMarker*>(object);
bbox = marker->getBBox();
return true;
return !bbox.isInverted();
}

void DbMarkerDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -5211,7 +5204,7 @@ bool DbScanInstDescriptor::getBBox(const std::any& object,
auto* scan_inst = std::any_cast<odb::dbScanInst*>(object);
auto* inst = scan_inst->getInst();
bbox = inst->getBBox()->getBox();
return true;
return !bbox.isInverted();
}

void DbScanInstDescriptor::highlight(const std::any& object,
Expand Down Expand Up @@ -5540,7 +5533,7 @@ bool DbBoxDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
bbox = getObject(object)->getBox();
const auto xform = getTransform(object);
xform.apply(bbox);
return true;
return !bbox.isInverted();
Comment on lines 5533 to +5536
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If bbox is inverted, applying the transform via xform.apply(bbox) will corrupt the coordinates (due to integer overflow/underflow during translation/rotation of INT_MAX/INT_MIN), which can make the box appear non-inverted and cause !bbox.isInverted() to incorrectly return true. It is safer to check if bbox is inverted and return false before applying the transform.

  bbox = getObject(object)->getBox();
  if (bbox.isInverted()) {
    return false;
  }
  const auto xform = getTransform(object);
  xform.apply(bbox);
  return true;

}

Selected DbBoxDescriptor::makeSelected(const std::any& object) const
Expand Down Expand Up @@ -5705,7 +5698,7 @@ std::string DbSBoxDescriptor::getTypeName() const
bool DbSBoxDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
{
bbox = getObject(object)->getBox();
return true;
return !bbox.isInverted();
}

void DbSBoxDescriptor::highlight(const std::any& object, Painter& painter) const
Expand Down Expand Up @@ -6000,7 +5993,7 @@ bool DbWireDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
const auto box = obj->getBBox();
if (box.has_value()) {
bbox = *box;
return true;
return !bbox.isInverted();
}
return false;
}
Expand Down Expand Up @@ -6080,7 +6073,7 @@ bool DbSWireDescriptor::getBBox(const std::any& object, odb::Rect& bbox) const
for (auto* box : obj->getWires()) {
bbox.merge(box->getBox());
}
return true;
return !bbox.isInverted();
}

void DbSWireDescriptor::highlight(const std::any& object,
Expand Down
5 changes: 5 additions & 0 deletions src/odb/src/db/dbITerm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,11 @@ dbITerm* dbITerm::getITerm(dbBlock* block_, uint32_t dbid)
Rect dbITerm::getBBox()
{
dbMTerm* term = getMTerm();
if (term->getMPins().empty()) {
Rect bbox;
bbox.mergeInit();
return bbox;
}
Rect bbox = term->getBBox();
Comment on lines +747 to 752
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of checking if getMPins().empty() and manually constructing an inverted bounding box, it is more robust and direct to check if the retrieved term->getBBox() is inverted. This handles both the empty pins case and any other scenario where the master terminal's bounding box is invalid, while also preventing the instance transform from being applied to an inverted bounding box (which would corrupt its coordinates due to overflow/underflow during translation/rotation).

  Rect bbox = term->getBBox();
  if (bbox.isInverted()) {
    return bbox;
  }

const odb::dbTransform inst_xfm = getInst()->getTransform();
inst_xfm.apply(bbox);
Expand Down
Loading