Skip to content

update function calls post signature change in opensta plus update sr…#10626

Merged
maliberty merged 7 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:or_update_sta_latest_0609
Jun 12, 2026
Merged

update function calls post signature change in opensta plus update sr…#10626
maliberty merged 7 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:or_update_sta_latest_0609

Conversation

@dsengupta0628

Copy link
Copy Markdown
Contributor

Summary

Update sta pointer plus update a few function calls to reflect new signature in OpenSTA

Type of Change

  • Refactoring

Impact

NA

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Related Issues

[Link issues here]

…c/sta ptr

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the calls to the escapeChars function in Clock.cpp and dbSdcNetwork.cc to include an additional null character argument, aligning with an updated signature. Additionally, the src/sta submodule has been updated to a newer commit. There are no review comments to address, and no further feedback is provided.

@dsengupta0628

Copy link
Copy Markdown
Contributor Author

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 marked this pull request as ready for review June 12, 2026 19:29
@dsengupta0628 dsengupta0628 requested review from a team as code owners June 12, 2026 19:29
@maliberty

Copy link
Copy Markdown
Member

Does this update have QoR implications?

@dsengupta0628

Copy link
Copy Markdown
Contributor Author

Does this update have QoR implications?

I do not expect any QoR change here- I had run secure CI too before the LVF crash fix - but that shouldn't change QoR.
The secure-ci shows some customer designs QoR change but they existed with reference branch too- so I just relaunched secure-ci with latest code: http://secure-ci:8080/view/My/job/SB/job/secure-or_update_sta_latest_0609/

@maliberty maliberty merged commit 14b1ef1 into The-OpenROAD-Project:master Jun 12, 2026
16 checks passed
@maliberty maliberty deleted the or_update_sta_latest_0609 branch June 12, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants