docs: clarify OSS best practices configuration - #2870
Conversation
PR Summary by QodoClarify OSS best-practices configuration
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
|
Code review by qodo was updated up to the latest commit 0bea585 |
IsmaelMartinez
left a comment
There was a problem hiding this comment.
Thanks for this, and the content checks out against the code.
The last push mixed line endings though, 368 CRLF against 18 LF, so a change of 18 added and 2 removed now reads as 384 added and 368 removed. Could you restore LF throughout?
The wrap that came with it answers Qodo's 120-character flag, which is configured in Qodo rather than in this repo, so it will keep firing on docs. I would leave that line as it was: improve.md already carries untouched lines of 472, 461 and 402 characters.
One content point. The block sits under the Platforms supported: GitHub, GitLab, Bitbucket banner at line 111, but repo_context_files also works on Gitea and Azure DevOps. additional_configurations.md:268 has the full list.
|
Addressed in 57a14b7. The file is now normalized to LF throughout, the Qodo Merge sentence is back on its original single line, and the OSS fallback explicitly lists GitHub, GitLab, Gitea, Bitbucket, and Azure DevOps. The cumulative PR diff is back to one file with 18 additions and 2 deletions, and git diff --check passes. Thanks for the precise review. |
IsmaelMartinez
left a comment
There was a problem hiding this comment.
Perfect, thank you for turning that round so quickly. Taking it from here, and thanks again for contributing.
Summary
best_practices.mdloading is a Qodo Merge featureconfig.repo_context_filesas the OSS configuration pathFixes #2377.
Validation
git diff --check.venv\Scripts\python -m mkdocs build -f docs/mkdocs.ymlThe documentation build completed successfully. It reported existing warnings about missing optional social-card imaging dependencies and existing unresolved documentation links.