Add Boyer-Moore Majority Vote algorithm #560
Merged
+133
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsatoshi99
force-pushed
the
add-boyer-moore-majority-vote
branch
from
90953e6 to
2d98762
Compare
Contributor
Author
|
@siriak , I've made one algorithm and made PR for review, please check and let me know if you have any feedback, Thanks. |
Member
|
Please fix the issues Codacy found |
- Add curly braces to single-statement if blocks (lines 16, 28) - Split multi-statement lines into separate lines (lines 16, 28) - Declare variables separately instead of comma-separated (line 24)
Contributor
Author
|
@siriak I've fixed all issues what Codacy found for this PR also, please check it again, Thanks. |
- Change null check from 'nums?.Length == 0' to 'nums == null || nums.Length == 0' - Fixes NullReferenceException when passing null array
0xsatoshi99
force-pushed
the
add-boyer-moore-majority-vote
branch
from
4dd44c3 to
94b4f75
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
=========================================
Coverage ? 96.86%
=========================================
Files ? 289
Lines ? 11903
Branches ? 1717
=========================================
Hits ? 11530
Misses ? 237
Partials ? 136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Boyer-Moore Majority Vote algorithm for finding majority elements in O(n) time and O(1) space.
Includes 10 test cases covering edge cases and various scenarios.
Contribution by Gittensor, learn more at https://gittensor.io/