fix: optimize Set by using struct{} instead of bool for memory efficiency #782
+4
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
Set
implementation by replacing thebool
value with an empty struct (struct{}
). This significantly reduces memory usage, especially for large data sets.Motivation
The
Set
previously used amap[T]bool
, where each value occupied at least one byte. Since the actual value in aSet
is irrelevant (presence of a key implies membership), this value can be replaced with an empty struct (struct{}
), which has zero memory allocation in Go.This change enhances memory efficiency without affecting functionality or performance negatively.
Changes
map[T]bool
withmap[T]struct{}
for Set implementation.Checklist