Skip to content

refactor: refactor Ceil and improved tests #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 10, 2025

Ceil Class Refactor:

  • Simplified the Ceil.ceil(double) method for better clarity and correctness.
  • Replaced (int) casting with (long) to handle edge cases and large numbers more safely.
  • Updated method-level JavaDoc and added class-level documentation for better understanding and maintainability.

Test Refactor:

  • Migrated CeilTest to use JUnit 5 @ParameterizedTest with @CsvSource.
  • Enhanced test readability, scalability, and coverage.
  • Ensures better structure and allows easier future additions of test cases.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (f325279) to head (2b6f328).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6366      +/-   ##
============================================
- Coverage     74.63%   74.63%   -0.01%     
  Complexity     5452     5452              
============================================
  Files           682      682              
  Lines         19017    19016       -1     
  Branches       3674     3674              
============================================
- Hits          14193    14192       -1     
  Misses         4265     4265              
  Partials        559      559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants