feat: added rotating calipers #6669
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Fix Rotating Calipers: Correct Diameter and Width Calculations
“This PR adds the Rotating Calipers algorithm and its tests. The CI may show unrelated test failures (e.g., BloomFilterTest), but my changes are isolated to the geometry package and pass all their own tests.”
Description:
This PR fixes the
RotatingCalipers
implementation for calculating the diameter and minimum width of convex polygons.Changes made:
diameter
method to correctly compute the farthest pair of points using the rotating calipers technique. Previous calculations returned incorrect distances for simple polygons.width
method to compute the true minimum width of the convex polygon, based on perpendicular projections along each edge.testDiameterSimpleTriangle
andtestWidthSimpleTriangle
to match the mathematically correct expected values.minAreaBoundingRectangle
, remain consistent with correct convex hull ordering.Impact:
Triangles and other simple polygons now return the correct diameter and width.
Unit tests pass with accurate geometric values.
References:
Rotating Calipers algorithm (Shamos, 1978)
Convex hull computation for ordered points