-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication #6678
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6678 +/- ##
============================================
- Coverage 76.45% 76.42% -0.04%
- Complexity 5985 5992 +7
============================================
Files 716 718 +2
Lines 20265 20307 +42
Branches 3929 3940 +11
============================================
+ Hits 15494 15519 +25
- Misses 4180 4189 +9
- Partials 591 599 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these if-else branches really necessary?
You’re manually handling every primitive array type here (byte[], int[], double[], etc.), but this can be simplified. Java’s reflection API allows a more concise and general approach — you can check key.getClass().isArray() and then use either Arrays.toString((Object) key) for primitive arrays or Arrays.deepToString((Object[]) key) for object arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn’t this class be a better fit for the math package?
clang-format -i --style=file path/to/your/file.java
What does this PR do?
Adds two new string algorithms:
RemoveStars
ComplexNumberMultiplication
Checklist
mvn clean verify
This is my contribution for Hacktoberfest 2025