Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gale-Shapley stable matching #35

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

ZoomRmc
Copy link
Contributor

@ZoomRmc ZoomRmc commented Jun 21, 2023

This is an adaptation of my much earlier implementation made for the RosettaCode project. The additional requirements of the task were moved to the runnableExamples block.

The code was updated, thoroughly checked and commented.

The name for the category is similar to one used for earlier C# and Lua implementations.

@ZoomRmc ZoomRmc requested a review from dlesnoff as a code owner June 21, 2023 13:27
This is an adaptation of my much earlier implementation made
for the RosettaCode project. The additional requirements of the
task were moved to the runnableExamples block.

The code was updated, thoroughly checked and commented.

The name for the category is similar to one used for earlier
C# and Lua implementations.
Copy link
Collaborator

@dlesnoff dlesnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a great review, but I think that the implementation is quite fine!
I will make another pass in a few days.

stable_marriage/gale_shapley.nim Show resolved Hide resolved
stable_marriage/gale_shapley.nim Show resolved Hide resolved
stable_marriage/gale_shapley.nim Show resolved Hide resolved
stable_marriage/gale_shapley.nim Outdated Show resolved Hide resolved
stable_marriage/gale_shapley.nim Outdated Show resolved Hide resolved
stable_marriage/gale_shapley.nim Show resolved Hide resolved
stable_marriage/gale_shapley.nim Show resolved Hide resolved
Copy link
Collaborator

@dlesnoff dlesnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contrib' !

@dlesnoff dlesnoff merged commit ed5aed2 into TheAlgorithms:main Jun 30, 2023
dlesnoff added a commit to dlesnoff/Nim-Algorithms that referenced this pull request Jul 4, 2023
* Implement Gale-Shapley stable matching

This is an adaptation of my much earlier implementation made
for the RosettaCode project. The additional requirements of the
task were moved to the runnableExamples block.

The code was updated, thoroughly checked and commented.

The name for the category is similar to one used for earlier
C# and Lua implementations.

* Add more docs; `Clash` made numerical

* Remove repetition in module's RE block

---------

Co-authored-by: dlesnoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants