feat: add haversineDistance
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
commented
Aug 31, 2024
vil02
force-pushed
the
add_haversineDistance
branch
from
a6d601f
to
a293bbb
Compare
vil02
force-pushed
the
add_haversineDistance
branch
from
a293bbb
to
0b223a1
Compare
ZoomRmc
reviewed
Sep 2, 2024
Co-authored-by: Zoom <[email protected]>
vil02
force-pushed
the
add_haversineDistance
branch
from
8a06cc7
to
5067bdb
Compare
vil02
force-pushed
the
add_haversineDistance
branch
from
587f0fb
to
470d5bb
Compare
ZoomRmc
approved these changes
Sep 3, 2024
dlesnoff
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
haversineDistancefunction.I realize that the
closefunction is ugly. I could not force thealmostEqualto work here.