Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix build_directory_md.yml #81

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

ZoomRmc
Copy link
Contributor

@ZoomRmc ZoomRmc commented Sep 5, 2024

Fixes the build_directory_md.yml action. Sets the Nim runtime dir as a forced git exclusion.

git clean removed the nim compiler directory, which jiro4989/setup-nim-action@v2 installs to $(pwd)/.nim_runtime.

This puts the nim install dir outside of the current project directory with:

  - uses: jiro4989/setup-nim-action@v2
    with:
      parent-nim-install-directory: ${{ runner.temp }}

@dlesnoff
Copy link
Collaborator

dlesnoff commented Sep 5, 2024

Contradicts this: #78 (review) from #78 discussion.
Are you sure this change is necessary?

@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Sep 5, 2024

Contradicts this: #78 (review) from #78 discussion. Are you sure this change is necessary?

Ah, sorry, didn't see that PR. Well, some change is necessary for the job to finish.
As I said, there's an alternative approach, which #78 already implements in another script.
I can change this PR for consistency.

@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Sep 6, 2024

Changed the fix to the other approach.

@dlesnoff dlesnoff merged commit 4a59ed8 into TheAlgorithms:main Sep 10, 2024
4 checks passed
@ZoomRmc ZoomRmc deleted the fix-build-yml branch September 10, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants