-
-
Notifications
You must be signed in to change notification settings - Fork 48.9k
feat(bit_manipulation): add swap_bits function with doctests (marked checkboxes) #13521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
""" | ||
Swap two bits at given positions in a non-negative integer using bitwise operators. | ||
|
||
Wikipedia reference: | ||
https://en.wikipedia.org/wiki/Bit_manipulation | ||
""" | ||
|
||
|
||
def swap_bits(number: int, i: int, j: int) -> int: | ||
""" | ||
Swap the bits at the position i and j (0-indexed from right side) | ||
|
||
Arguments: | ||
number (int): Non-negative integer whose bits are to be swapped. | ||
i (int): Index of 1st bit to swap. | ||
j (int): Index of 2nd bit to swap. | ||
|
||
Returns: | ||
int: Integer obtained after swapping of bits. | ||
|
||
Raises: | ||
TypeError: If argument is not an Integer | ||
ValueError: Invalid argument or bit positions. | ||
|
||
Examples: | ||
>>> swap_bits(28, 0, 2) # 11100 -> swap rightmost bits 0 and 2 | ||
25 | ||
>>> swap_bits(15, 1, 2) # 1111 -> swapping the bits 1 and 2 | ||
15 | ||
>>> swap_bits(10, 0, 3) # 1010 -> swap the bits 0 and 3 | ||
3 | ||
>>> swap_bits(10.5, 0, 3) | ||
Traceback (most recent call last): | ||
... | ||
TypeError: All arguments MUST be integers! | ||
>>> swap_bits(-5, 1, 3) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: The number MUST be non-negative! | ||
>>> swap_bits(10, -1, 2) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: Bit positions MUST be non-negative! | ||
""" | ||
if not all(isinstance(x, int) for x in (number, i, j)): | ||
raise TypeError("All arguments MUST be integers!") | ||
|
||
if number < 0: | ||
raise ValueError("The number MUST be non-negative!") | ||
|
||
if i < 0 or j < 0: | ||
raise ValueError("Bit positions MUST be non-negative!") | ||
|
||
# Extraction of Bits | ||
bit_first = (number >> i) & 1 | ||
bit_second = (number >> j) & 1 | ||
|
||
# If bits differ swap them | ||
if bit_first != bit_second: | ||
number ^= (1 << i) | (1 << j) | ||
|
||
return number | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide descriptive name for the parameter:
i
Please provide descriptive name for the parameter:
j
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I'll make the changes