-
-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Add palindrome number checker with user input #14066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds a simple Python implementation to check whether a number is a palindrome using user input.
himudigonda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string slicing (str(n)[::-1]) method is idiomatic Python but inefficient. I suggest a mathematical approach using modular arithmetic to achieve
🔍 Analysis
| Metric | Original (String-based) | Optimized (Mathematical) |
|---|---|---|
| Time Complexity | ||
| Space Complexity |
|
|
| Mathematical Correctness | Relies on string reversal | Handles digit logic natively |
🛠️ Refactored Implementation
def is_palindrome(number: int) -> bool:
"""
Determines if an integer is a palindrome without string conversion.
Logic:
1. Filter out negative numbers and multiples of 10.
2. Reverse the second half of the number.
3. Compare the two halves.
"""
# Negative numbers and numbers ending in 0 (except 0) are not palindromes
if number < 0 or (number % 10 == 0 and number != 0):
return False
reversed_half = 0
# Reverse only half of the digits to prevent overflow and save time
while number > reversed_half:
reversed_half = (reversed_half * 10) + (number % 10)
number //= 10
# For even digits: number == reversed_half
# For odd digits: number == reversed_half // 10 (removes middle digit)
return number == reversed_half or number == reversed_half // 10Refactor palindrome check to avoid string conversion and improve logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,18 @@ | |||
| def is_palindrome(number: int) -> bool: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file maths/palindrome_number.py, please provide doctest for the function is_palindrome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added required doctests for is_palindrome as requested. Please review.
Adds a simple Python implementation to check whether a number is a palindrome using user input.
Includes basic input handling and examples.
Describe your change:
Checklist: