Repository navigation
Conversation
Rust's integer parser accepts "+1" as 1, so ipv4_to_decimal and alt_ipv4_to_decimal treated 192.168.0.+1 as a valid address. Require each octet to be decimal digits only and add regression tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
- Coverage 95.89% 95.87% -0.02%
==========================================
Files 396 396
Lines 30441 30451 +10
==========================================
+ Hits 29192 29196 +4
- Misses 1249 1255 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject IPv4 octets that are not decimal digits, including values with a leading
+.Why
u32::from_straccepts"+1"as1, soipv4_to_decimal("192.168.0.+1")andalt_ipv4_to_decimalreturned a successful result for an address that is not valid IPv4.Tests
Added cases for a leading
+on both conversion functions.