Fix ASN1 freezes and latency on big input #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that rendering absolute all bytes of the asn1 node is a bad idea (ironically). It has caused big performance problems and latency. Now we render only first `MAX_BYTES_TO_RENDER` / 2 and last `MAX_BYTES_TO_RENDER` / 2 bytes of the asn1 node if the overall amount of bytes is greater than `MAX_BYTES_TO_RENDER`. Currently, `MAX_BYTES_TO_RENDER` is equal to `512`.
TheBestTvarynka
added
bug
cloning. Previously, for every hex byte node, NodeOptions component, copy operation, and so on, the app has cloned entire node bytes. This patch introduces the `RcSlice` structure. This structure represents the slice with multiple owners. But actually, it's just a `Vec` in the `Rc` plus range. These changes affect the hex viewer and `NodeOptions` components the most. We don't want to cause a big refactoring for now. We have better performance and memory efficiency. `Vec`s cloning now is not a bottleneck. But the noticeable freezes are still present.
and formatting hacks.
Reduced different conversions from `T` into `Classes` as much as possible.
It was unexpected, but a lot of `Classes` object constructions can cause
performance issues.
Replaced the `format!("{:02x?}", byte)` macro invocation with a simple
function with a big match that returns a static string.
Add one byte to the overall length. This byte represents the 'Z' chat, that usuallu is placed in the end of the utc time object.
Now the data will also be set in the input textarea during loading from local storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53
read commit messages for more details