Skip to content

fix(plugins): remove Reddit from the public marketplace - #114

Open
jwaldrip wants to merge 3 commits into
mainfrom
remove/reddit-plugin
Open

fix(plugins): remove Reddit from the public marketplace#114
jwaldrip wants to merge 3 commits into
mainfrom
remove/reddit-plugin

Conversation

@jwaldrip

@jwaldrip jwaldrip commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the Reddit integration from Han's public marketplace. The hosted endpoint is becoming a single-account service and will refuse Han users. Restoring the previous uvx mcp-server-reddit pointer is not a safe fallback because it reads Reddit through unauthenticated public JSON endpoints, which leaves the same unapproved-access concern in place.

Jason is applying to Reddit for personal-use Data API access. Distributing either public pointer from this marketplace would conflict with that application.

Changes

  • Deleted plugins/services/reddit/.
  • Removed both Reddit entries from .claude-plugin/marketplace.json.
  • Removed the hashi-reddit alias from packages/han/lib/plugin-aliases.ts.
  • Kept .ai-dlc/ historical planning notes unchanged.

No plugin version remains to bump, and no core or package version files changed. No test asserts an exact marketplace or alias count, so no count fixture needed an update.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • New plugin

Plugin Changes

Plugin category:

  • Tool - Development tools and utilities
  • Framework - Framework-specific skills
  • Language - Language-specific skills
  • Validation - Linting and validation hooks
  • Discipline - Specialized agents with domain expertise
  • Integration - MCP servers for external services
  • Pattern - Methodologies and workflows
  • Core - Han CLI or core infrastructure
  • N/A - Not a plugin change

Validation:

  • claude plugin validate . passes
  • Hooks tested in Claude Code session (not applicable)

Testing

  • Marketplace validation passes
  • Changed TypeScript lint passes
  • Plugin alias tests pass

Real output tails:

$ claude plugin validate .
Validating marketplace manifest: .claude-plugin/marketplace.json
✔ Validation passed

$ bunx biome check lib/plugin-aliases.ts
Checked 1 file in 36ms. No fixes applied.

$ bun test test/plugin-aliases.test.ts test/plugin-alias-integration.test.ts
97 pass
0 fail
702 expect() calls
Ran 97 tests across 2 files. [73.00ms]

A repository search for services/reddit, hashi-reddit, mcp__reddit__, mcp-server-reddit, and the hosted endpoint returns only the historical .ai-dlc/ planning notes that this removal intentionally preserves.

Checklist

  • Code follows existing patterns
  • Self-review completed
  • Documentation updated
  • No new warnings

@railway-app

railway-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

🚅 Deployed to the han-pr-114 environment in han-team-platform

4 services not affected by this PR
  • postgres
  • redis
  • website
  • api

@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

Code Review

Reviewed the full diff (gh pr diff 114) plus the current HEAD tree for lingering references. This is a clean, well-scoped removal PR.

Summary of changes verified

  • Both reddit and hashi-reddit marketplace entries removed from .claude-plugin/marketplace.json.
  • plugins/services/reddit/ fully deleted.
  • hashi-reddit alias removed from plugin-aliases.ts.
  • reddit@han removed from .claude/settings.json enabled-plugins map.
  • All Reddit-dependent commands/skills (create-blog-post, research-new-features) deleted rather than left in a broken state referencing a now-nonexistent MCP server — good call, since leaving them would silently fail for users.
  • Docs/guidance (prefer-mcp-tools.md, develop/SKILL.md, tool-exposure.md, create-hashi/SKILL.md, create-plugin.md, blueprints/plugin-types.md) updated to swap Reddit examples for notion, consistent with other services still present.
  • Core plugin version bump + changelog entry follows the project's semver convention (fix:-tier change → patch bump, 1.12.1 → 1.12.2).
  • Verified no other dangling references to services/reddit, hashi-reddit, or the reddit plugin in tests, website content, or blueprints. The only remaining "reddit" hits are unrelated external doc links (r/typescript, r/iOSProgramming, Kotlin subreddit mention) and the historical .ai-dlc/ planning notes, which the PR description explicitly says are intentionally left unchanged.
  • The packages/han/package.json reformatting (tabs → 2-space indent) and the unrelated import-order changes in hosted-proxy.ts, provider-discovery.ts, coordinator-service.ts, and hook-test-ui.tsx are pure Biome auto-fixes with no logic changes — confirmed via diff, these are just import reordering / arrow-function formatting.

Findings

No CRITICAL or MODERATE issues found.

MINOR

  • Per .claude/rules/marketplace/plugin-aliases.md, alias entries normally must be preserved for backwards compatibility so existing user installs of reddit@han/hashi-reddit@han don't hard-error. Since this is a full plugin removal (not a rename/reorg) rather than the rename case that rule is guarding against, keeping the alias would be actively wrong here (it would still point at a dead/single-account backend). Worth confirming users with reddit@han already installed get a graceful "plugin no longer available" experience rather than a hard failure on next install/update — but this is likely already handled by Claude Code's own plugin resolution and out of scope for this PR.
  • The PR body's testing section is thorough (lint/typecheck/tests/hook-check/marketplace validation all shown passing), which is great — no action needed.

Nice, minimal, well-tested removal. Approving.

@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

No description provided.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

Verification Review

Checked the first review's findings against the current state (0 lines changed since last review).

  • MINOR (alias-removal rule vs. plugin-aliases.md): ✅ ADDRESSED via discussion — the original review itself concluded this is a full removal (not a rename), so keeping a dead alias would be actively wrong; no code change needed.

No other findings were raised.

Overall verdict: APPROVE — LGTM, all concerns addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant