Open
Conversation
NL66278
reviewed
Jan 26, 2026
| @@ -1,5 +1,5 @@ | |||
| # Copyright 2023 Solvti sp. z o.o. (https://solvti.pl). | |||
| # Copyright 2025-2026 Therp BV (https://therp.nl). | |||
Author
There was a problem hiding this comment.
It is outdated, there's no actual change
NL66278
requested changes
Jan 26, 2026
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
It seems a few of the improvements (constraint added), unneeded cleaning after tools email split) that where in the last commit on 16.0, have been removed in the last commit here. This also shows in the copyright lines that remove the 2026.
Author
|
@NL66278 I just cherry-picked that one commit |
|
@ntsirintanis Please smash the last cherry-picked commit in the one before, then we have a clear view of what was needed for the backport (as far as I can see not very much). |
[FIX] mail_alias_with_domain: review remarks
ntsirintanis
force-pushed
the
14.0-mig-mail_alias_with_domain
branch
from
de52872 to
978c7b2
Compare
|
@ntsirintanis And please put this one also in the OCA repo |
- Add test for write on mail.alias; - No unneeded call to clean already clean email; - Add constraint to mail.alias.
ntsirintanis
force-pushed
the
14.0-mig-mail_alias_with_domain
branch
from
9ce6cdb to
11d7614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.