Added ability to search for blocknames and ids like OAB used to have#1
Open
Denevien wants to merge 5 commits intoThezomg:masterfrom
Denevien:master
Open
Added ability to search for blocknames and ids like OAB used to have#1Denevien wants to merge 5 commits intoThezomg:masterfrom Denevien:master
Denevien wants to merge 5 commits intoThezomg:masterfrom
Denevien:master
Conversation
Uses .search SEARCHTYPE INPUT Searchtypes: "name" and "id". Inputs: "name" - 1 word keyword: uses the block name to return a list of block names that contain the keyword and the id for that block. "id" - can be "###" or "###:###": uses the block ID to return the block name.
Contributor
|
Thoughts: not async and file doesn't need to be reopened many times anyway; id based search can be much more efficient; no need to be told a search type when we could figure it out from the search term. |
Author
|
Thanks for the feedback, this is my first real attempt at python, so wanted
|
…rent id search id 3 now properly returns both dirt and podzol, instead of just the podzol.
…tax and no results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.