Adds rudimentary video support #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: adds video link to description (it's a wip, don't judge)
|
Is something blocking this PR to go through? Would really like to use this as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Pull request description
Adds video support to the Thijstool in a very rudimentary way by manually recreating the URL from the episode ID and placing that in the description. Adds three new env vars:
ENABLE_VIDEOenables this (pre-alpha) functionalityENABLE_VIDEO_CHECKenables functionality that makes a get request to the video url, only adding/marking if a video exists thereVIDEO_TITLE_SUFFIXis a suffix that's added to podcast titles iff ENABLE_VIDEO and ENABLE_VIDEO_CHECK and the video URL refers to an actual video.