Drop deprecated repo_name passed to gitlabr::use_gitlab_ci() - #78
Open
VincentGuyader wants to merge 1 commit into
Open
Drop deprecated repo_name passed to gitlabr::use_gitlab_ci()#78VincentGuyader wants to merge 1 commit into
VincentGuyader wants to merge 1 commit into
Conversation
`gitlabr::use_gitlab_ci()` removed the `repo_name` parameter in 2.1: the CRAN mirror is now read from the `REPO_NAME` GitLab CI/CD variable in the generated YAML (see gitlabr's bookdown-production.yml template), not from a function argument. lozen still passed `repo_name = repo_name` and so errored with `unused argument`. The lozen `repo_name` parameter is kept in the signature for backward compatibility but documented as deprecated and emits a warning when set explicitly. The internal call to gitlabr no longer forwards it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
R-CMD-checkettest-coverageétaient rouges surmaindepuis 2025-10-23 :```
Error in `gitlabr::use_gitlab_ci(image = image, repo_name = repo_name, path = ci_file, type = type)`:
unused argument (repo_name = repo_name)
```
Cause
gitlabr2.1 a supprimé l'argumentrepo_name. Le mirror CRAN est désormais paramétré dans le template YAML via la variable CI/CDREPO_NAME(cf. `inst/gitlab-ci/bookdown-production.yml` chez gitlabr) plutôt qu'en argument de fonction.Fix
repo_nameà `gitlabr::use_gitlab_ci()`.Test
```
Les tests précédemment rouges (`test-use_gitlab_ci.R:5:5` et `test-check_if_yaml_exists.R:5:5`) passent. Les SKIPs sont des tests `skip_on_ci()` existants pour scénarios bookdown/golem qui demandent un GitLab réel.