v1.3.17#99
Merged
Merged
Conversation
Remove legacy .flake8 and add ruff.toml to migrate linting to ruff (target py312). ruff configuration selects pycodestyle (E) and pyflakes (F) checks, preserves previous ignored E-codes, and adds per-file ignore for __init__.py imports. Also update .vscode/settings.json to set the workspace venv interpreter path and add python-envs.pythonProjects configuration (plus minor cSpell list formatting). These changes align editor settings and linting configuration with the project's ruff-based setup.
Expose a new "enable_ime" option in the equipment UI and propagate it to the daemon so the virtual keyboard (IME) can be enabled/disabled per device. Core: send enable_ime (default 1) with device info. Desktop: add a Compatibilité section with the IME checkbox and adjust the legend label. Daemon: accept enable_ime from socket messages, log its state, pass it into EQRemote and into AndroidTVRemote (enable_ime parameter). Also bump plugin version to 1.3.17.
Add migration v1.3.17 in plugin_info/install.php to set the 'enable_ime' configuration to 1 for all existing tvremote eqLogic instances when the setting is unset, and persist the change. Ensures the new default is applied to older equipments.
When creating eqLogic entries during a device scan, set the 'enable_ime' configuration to 1 and save the object. This ensures the input method editor (IME) is enabled by default for tvremote devices to support text input features.
Add daemon state checks to enable/disable methods. Each of enableTVRemoteToDaemon, enableADBToDaemon, disableTVRemoteToDaemon and disableADBToDaemon now calls self::deamon_info() and, if the daemon state is not 'ok', logs a debug message and returns early to avoid sending commands when the daemon isn't started.
Rename the section header from 'Compatibilité' to 'Paramètres avancés' and refine the French tooltip for 'Clavier Virtuel (IME)' to clarify default behavior: that it retrieves the current app name and allows sending text via the virtual keyboard, and to advise when to disable it. No functional logic changes.
Refines the French tooltip for the "Clavier Virtuel (IME)" option to be shorter and clearer. The new text explicitly states that enabling allows the "Current App" command and text input, while disabling should be used if the TV shows "Utiliser le clavier sur votre smartphone" instead of the built-in keyboard. Change applied to desktop/php/tvremote.php.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Virtual Keyboard (IME)" configuration option for TV Remote devices, improves robustness when communicating with the daemon, and updates development environment settings and linting configuration. The changes ensure that the IME setting is properly initialized, exposed in the UI, and passed through the entire stack to the Python daemon. Additionally, the plugin version is incremented and development tooling is updated.
TV Remote IME (Virtual Keyboard) Feature:
enable_imeconfiguration option for TV Remote devices, defaulting to enabled. This setting is now initialized for existing devices during upgrade and included in device creation and updates. (core/class/tvremote.class.php,plugin_info/install.php,public static function createAndUpdTVRemoteFromScan,plugin_info/info.json, [1] [2] [3]desktop/php/tvremote.php, desktop/php/tvremote.phpR205-R214)enable_imeparameter when creating and managing remote devices, ensuring the IME setting is respected at runtime. (resources/tvremoted/tvremoted.py, [1] [2] [3]Daemon Communication Robustness:
core/class/tvremote.class.php, [1] [2] [3]UI and Documentation Updates:
desktop/php/tvremote.php, [1] [2]Development Environment and Linting:
ruff.tomlconfiguration for Python linting, replacing the previous.flake8file. (.vscode/settings.json, [1] [2];ruff.toml, [3];.flake8, [4]Versioning:
1.3.17to reflect these changes. (plugin_info/info.json, plugin_info/info.jsonL4-R4)